-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[core, GPU, NPU]Remove deprecated code in core for ov::cache_dir
#32658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[core, GPU, NPU]Remove deprecated code in core for ov::cache_dir
#32658
Conversation
- remove ov::cache_dir as supported property in GPU and NPU - update core tests Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Signed-off-by: Pawel Raasz <[email protected]>
Retribution98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS part is ok
…che-dir-from-devices
…che-dir-from-devices
Signed-off-by: Raasz, Pawel <[email protected]>
| ov::PropertyName{ov::intel_gpu::hint::enable_lora_operation.name(), PropertyMutability::RW}, | ||
| ov::PropertyName{ov::intel_gpu::enable_loop_unrolling.name(), PropertyMutability::RW}, | ||
| ov::PropertyName{ov::intel_gpu::disable_winograd_convolution.name(), PropertyMutability::RW}, | ||
| ov::PropertyName{ov::cache_dir.name(), PropertyMutability::RW}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPU plugin uses cache_dir for OPTIMIZE_SIZE mode.
| auto path = _config.get_cache_dir(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How it can be solved on GPU side?
This property should not be passed to devices as it is core property.
| TRY_REGISTER_SIMPLE_PROPERTY(ov::compilation_num_threads, COMPILATION_NUM_THREADS); | ||
| TRY_REGISTER_SIMPLE_PROPERTY(ov::hint::inference_precision, INFERENCE_PRECISION_HINT); | ||
| TRY_REGISTER_SIMPLE_PROPERTY(ov::log::level, LOG_LEVEL); | ||
| TRY_REGISTER_SIMPLE_PROPERTY(ov::cache_dir, CACHE_DIR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still have access to it? We need to know if the OV cache is enabled to disable driver cache.
Details:
ov::cache_dirto hardware pluginsov::cache_dirfrom supported propertiesTickets: